-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-framework): Add UseSession attribute to replace annotation #36363
Merged
ChristophWurst
merged 1 commit into
master
from
feat/app-framework/usesession-attribute
Jan 27, 2023
Merged
feat(app-framework): Add UseSession attribute to replace annotation #36363
ChristophWurst
merged 1 commit into
master
from
feat/app-framework/usesession-attribute
Jan 27, 2023
+189
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
rullzer,
vitormattos,
juliusknorr,
miaulalala and
julien-nc
January 25, 2023 18:30
zak39
reviewed
Jan 25, 2023
rullzer
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fancy pancy
miaulalala
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChristophWurst
force-pushed
the
feat/app-framework/usesession-attribute
branch
from
January 26, 2023 12:47
af46e6a
to
7f39c72
Compare
ChristophWurst
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jan 26, 2023
juliusknorr
approved these changes
Jan 27, 2023
The autoloaders are not up to date |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
feat/app-framework/usesession-attribute
branch
from
January 27, 2023 08:40
7f39c72
to
20e00cd
Compare
nickvergessen
added
the
pending documentation
This pull request needs an associated documentation update
label
Jan 29, 2023
Please document in #34692 |
ChristophWurst
removed
the
pending documentation
This pull request needs an associated documentation update
label
Jan 30, 2023
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://help.nextcloud.com/t/how-should-we-use-php8-attributes/104278
TODO
Checklist